Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to set any parameter to notification #23

Merged

Conversation

matt-pawley
Copy link

Adds a setParameter method to OneSignalMessage to allow the setting of any API parameter.

Example usage:

public function toOneSignal($notifiable)
{
        return OneSignalMessage::create()
            ->subject('Example')
            ->body('Example body')
            ->setParameter('ios_badgeType', 'Increase')
            ->setParameter('ios_badgeCount', 1);
}

Would fix #16

@sald19
Copy link

sald19 commented Sep 8, 2017

Any update on this?

@matt-pawley
Copy link
Author

@sald19 - I've no idea if this will ever be merged, if you want to use my fork, you can do so by updating your composer.json as follows:

 "repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/toughdeveloper/onesignal"
    }
],
"require": {
    "laravel-notification-channels/onesignal": "dev-master"
},

@Lloople Lloople requested a review from LKaemmerling January 5, 2018 00:29
@LKaemmerling LKaemmerling merged commit 934faf2 into laravel-notification-channels:master Jan 5, 2018
@LKaemmerling
Copy link
Collaborator

@toughdeveloper Thank you for your contribution! I will add Tests for this and then we could release the next version from this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional API parameters
4 participants