Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for version 4.0 of laravel-firebase #98

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

dododedodonl
Copy link
Contributor

@dododedodonl dododedodonl commented Jan 13, 2022

Resolves #97

I tested installing and a simple notification test via a token, and this is successful.

@atymic
Copy link
Member

atymic commented Feb 1, 2022

Is it possible to support the latest version (ie 6)?

@dododedodonl
Copy link
Contributor Author

4.0 is the latest version for the kreait/laravel-firebase package. Version 4.0 depends on kreait/firebase-php package version 6.

@atymic
Copy link
Member

atymic commented Feb 5, 2022

Ahh right. Does this address the breaking changes in v4?

@dododedodonl
Copy link
Contributor Author

dododedodonl commented Feb 5, 2022

The version number of kreait/laravel-firebase just lags behind that of kreait/firebase-php. Some deprecated facades and configs were removed, and minimum laravel version got bumped to 8 for kreait/laravel-firebase. In kreait/firebase-php a few packages got a newer minimum version, but the basic api remains the same. As far as I can tell and tested, no features changed that are used in the notification channel.

@Afrowson
Copy link

Afrowson commented Feb 8, 2022

I second this and can confirm it. Started to work on it my selfe today at work.

We use it and want to update to php8.1. It did work in our testing environment.

@jeromegamez
Copy link

I just wanted to chime to say how amazing it is that you managed to keep backward compatibility to the Firebase package down to v1.3 🤯, great work!

@tobiasnitsche
Copy link

tobiasnitsche commented Feb 14, 2022

Any news on this?

@atymic atymic merged commit 11666ea into laravel-notification-channels:master Feb 15, 2022
@atymic
Copy link
Member

atymic commented Feb 15, 2022

Can you have a go at installing dev-master. If all is working i'll tag a new version :)

@marcroberts
Copy link
Contributor

Looks good to me 👍

@dododedodonl
Copy link
Contributor Author

Works the same as I tested before! Thanks!

@atymic
Copy link
Member

atymic commented Feb 15, 2022

Ta!

@tobiasnitsche
Copy link

I tested too. Looks all fine! Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support kreait/firebase-php v6.x
6 participants