Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Silence Passing null to class_exists() deprecation warning #568

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

soltmar
Copy link
Contributor

@soltmar soltmar commented Oct 25, 2023

Since PHP 8.1 passing null to class_exists() is deprecated. I have re-factored SubstituteBindings::getClassName() to silence deprecation warning

This change could possibly be ported to other branches as well.

Since PHP 8.1 passing null to class_exists() is deprecated.
I have re-factored SubstituteBindings::getClassName() to silence deprecation warning
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab656aa) 66.15% compared to head (c3e368f) 66.15%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.0     #568   +/-   ##
=========================================
  Coverage     66.15%   66.15%           
  Complexity      548      548           
=========================================
  Files            81       81           
  Lines          1764     1764           
=========================================
  Hits           1167     1167           
  Misses          597      597           
Files Coverage Δ
src/Middleware/SubstituteBindings.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eigan eigan merged commit 1789dac into laravel-doctrine:2.0 Oct 26, 2023
6 checks passed
@eigan
Copy link
Member

eigan commented Oct 26, 2023

Thanks 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants