Adding PHP 8 support #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, I'm not sure how to update the build strategy to only build the 2.8.0 orm with PHP 8. |
|
@tezhm try this: name: PHP ${{ matrix.php }} - doctrine/orm ${{ matrix.orm }}
strategy:
matrix:
php: ['7.2', '7.3', '7.4', '8.0']
orm: ['2.6.0', '2.7.0', '2.8.0']
+ exclude:
+ - php: '8.0'
+ orm: 2.6.0'
+ - php: '8.0'
+ orm: 2.7.0'
steps:
- uses: actions/checkout@v2
- name: Setup PHP
|
tezhm
force-pushed
the
php-8-support
branch
4 times, most recently
from
5f1cc12 to
e7213b9
Compare
eigan
reviewed
Mar 17, 2021
tezhm
force-pushed
the
php-8-support
branch
2 times, most recently
from
73147a3 to
24b5a87
Compare
|
No worries man, glad to help out. |
|
Should be released with 1.2.1 now @tezhm. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #70
Updates dependencies to include PHP 8 support.