Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLD-3 Add custom options attribute to ConnectionManager #5

Merged
merged 4 commits into from
Dec 12, 2017

Conversation

SergeyPodgornyy
Copy link
Member

Description

Add ability to add custom options while connection using ConnectionManager

Motivation and context

Add missing functionality

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@SergeyPodgornyy SergeyPodgornyy self-assigned this Dec 12, 2017
@SergeyPodgornyy SergeyPodgornyy merged commit 82868ce into master Dec 12, 2017
@SergeyPodgornyy SergeyPodgornyy deleted the feature/PLD-3_add_options_to_PDOManager branch December 12, 2017 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant