Fix the database dependencies #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chewi
commented
Dec 19, 2014
chewi
commented
- Don't include MySQL recipes when not using MySQL.
- Don't include mysql::client at all, database::mysql is sufficient.
- Do include database::postgresql when using PostgreSQL.
- Bump database dependency due to breaking changes in mysql-chef_gem.
- Demote mysql and postgresql cookbooks to "suggests" as they are not strictly required.
|
+1 |
|
Latest "database" seems to completely break everything. Maybe we should limit it with the 2.3.1? |
|
Can you elaborate please? |
|
For example, there is no database::mysql in latest database cookbook And current zabbix::database directly calls it. |
|
It was good up until 4.0.2. It has disappeared for a good reason though. The mysql2_chef_gem cookbook should now be used. This change explains the situation quite well. |
|
I agree completely. But current laradji/zabbix/master is not adapted for a change. That's why I proposed to limit database to 2.3.1 or any latest working version. Because berkshelf will pull mysql-6.x and database-5.x from current config and it will never work. |
- Don't include MySQL recipes when not using MySQL. - Don't include mysql::client at all, database::mysql is sufficient. - Do include database::postgresql when using PostgreSQL. - Bump database dependency due to breaking changes in mysql-chef_gem. - Demote mysql and postgresql cookbooks to "suggests" as they are not strictly required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.