Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions for non-superusers to use lantern.async_task #314

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

Ngalstyan4
Copy link
Contributor

@Ngalstyan4 Ngalstyan4 commented Apr 17, 2024

- Grant necessary permissions to pg_cron resources and lantern.tasks
  table
- Refactor pg_cron unscheduling logic to bypass pg_cron unscheduling
related issue: citusdata/pg_cron#320
citusdata/pg_cron#320
Copy link

Benchmarks

metric old new pct change
recall (after create) 0.955 0.957 +0.21%
recall (after insert) 0.000 0.000 -
select tps 21187.376 25400.857 +19.89%
select bulk(100) tps 38.900 38.918 +0.05%
select latency (ms) 0.903 ± 1.537𝜎 0.786 ± 1.132𝜎 -12.96%
select bulk(100) latency (ms) 772.681 ± 159.570𝜎 770.137 ± 138.429𝜎 -0.33%
create latency (ms) 350606.678 350343.187 -0.08%
insert tps 478.754 483.984 +1.09%
insert bulk(100) tps 5.086 5.004 -1.60%
insert latency (ms) 66.084 ± 18.278𝜎 65.305 ± 18.262𝜎 -1.18%
insert bulk(100) latency (ms) 6126.782 ± 182.263𝜎 6202.568 ± 197.022𝜎 +1.24%
disk usage (bytes) 8196194304.000 8196194304.000 -

Copy link

The update tests on Linux failed. Please check the logs for more details.

10 similar comments
Copy link

The update tests on Linux failed. Please check the logs for more details.

Copy link

The update tests on Linux failed. Please check the logs for more details.

Copy link

The update tests on Linux failed. Please check the logs for more details.

Copy link

The update tests on Linux failed. Please check the logs for more details.

Copy link

The update tests on Linux failed. Please check the logs for more details.

Copy link

The update tests on Linux failed. Please check the logs for more details.

Copy link

The update tests on Linux failed. Please check the logs for more details.

Copy link

The update tests on Linux failed. Please check the logs for more details.

Copy link

The update tests on Linux failed. Please check the logs for more details.

Copy link

The update tests on Linux failed. Please check the logs for more details.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

The update tests on Linux failed. Please check the logs for more details.

Copy link

The update tests on Linux failed. Please check the logs for more details.

@Ngalstyan4 Ngalstyan4 merged commit e429cf9 into main Apr 26, 2024
44 of 45 checks passed
@Ngalstyan4 Ngalstyan4 deleted the narek/pg_cron-permission-fixes branch April 26, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant