Narek/storage upgrade #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ngalstyan4
force-pushed
the
narek/storage-upgrade
branch
from
440e570
to
bd11f64
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
==========================================
- Coverage 77.26% 75.68% -1.58%
==========================================
Files 23 23
Lines 1869 1929 +60
Branches 480 505 +25
==========================================
+ Hits 1444 1460 +16
- Misses 220 247 +27
- Partials 205 222 +17
|
Ngalstyan4
force-pushed
the
narek/storage-upgrade
branch
2 times, most recently
from
a9ad205
to
24f944b
Compare
This was referenced Jan 29, 2024
Ngalstyan4
force-pushed
the
narek/storage-upgrade
branch
3 times, most recently
from
4fb29f1
to
abeac7a
Compare
Ngalstyan4
force-pushed
the
narek/storage-upgrade
branch
2 times, most recently
from
fd4316a
to
dcce645
Compare
Ngalstyan4
commented
Feb 4, 2024
| uint32 neighbors_nr; | ||
| uint32 neighbors_max; | ||
| uint32 *neighbors; | ||
| uint32 unused; | ||
|
|
||
| LDB_VI_READ_NODE_CHUNK(vi_node, vi_node->vn_label, node_tape, &tape_pos, node_tape_size); | ||
| LDB_VI_READ_NODE_CHUNK(vi_node, vi_node->vn_dim, node_tape, &tape_pos, node_tape_size); |
There was a problem hiding this comment.
deleted because new binary index does not contain this information, so there is no room for inconsistency
…ment in UBSAN mode
When I ran the old command on a machine that had a really old lantern (v0.0.3), I noticed that it was never updated to the latest version and the old version ran instead. This makes sure that does not happen with our default docker command
Update usearch Remove hnswlib dependency Get closer to upstream usearch API Switch to using usearch_search_ef - new upstream compatible API in C api of usearch Update stroage level for external index generation
…ndomness Newer storage made the index slightly smaller which put old m=4 sift 1k index be near the border of a filled index page. As a result, depending on level distribution in a run, the regression test would have a differently sized index and result in a failure. Here we increase m slighly, to make it very unlikely a test will fail as a result of level randomness
Ngalstyan4
force-pushed
the
narek/storage-upgrade
branch
2 times, most recently
from
96be1b7
to
3cc22f4
Compare
Ngalstyan4
force-pushed
the
narek/storage-upgrade
branch
from
3cc22f4
to
282d056
Compare
We always create a new usearch instance per search, and always use it from a single thread, so no need to allocate resources for more threads
Ngalstyan4
force-pushed
the
narek/storage-upgrade
branch
from
282d056
to
7534dc4
Compare
Ngalstyan4
force-pushed
the
narek/storage-upgrade
branch
from
fb55a12
to
5164a93
Compare
Ngalstyan4
force-pushed
the
narek/storage-upgrade
branch
from
5164a93
to
dc216a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.