Check for undefined symbols #145 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please comment each line with some info on why we need it. the old code comments could help. Also, please test locally that if you create an undefined function, this check fails, even when compilation of the shared library succeeds. Otherwise, looks good! |
var77
force-pushed
the
feature/ci-check-undefined-symbols
branch
from
c0d04b4
to
1e614b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have modified
scripts/extern_defined.shscript to get the postgres binary dependencies dynamic and also get postgres binary path frompgconfig.Now there will be check in CI for undefined symbols in our binary.
For test I have added undefined function in our hnsw.h header file and the called that function from hnsw.c file. The check is returning the missing symbol correctly
closes #145