Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make writer fw_tag windows compatible #721

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Conversation

DumbMice
Copy link
Contributor

@DumbMice DumbMice commented Nov 2, 2023

In add_scalars, fw_tag is actually a path, which should be handled by os.path.join(str(fw_logdir), main_tag, tag) rather than fw_logdir+'/'+ main_tag+'/'+ tag which only works on unix systems.

This fix bugs which might occur on windows platform.

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
tensorboardX/writer.py 86.41% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@lanpa lanpa merged commit ce08ab4 into lanpa:master Nov 12, 2023
10 checks passed
@lanpa
Copy link
Owner

lanpa commented Nov 12, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants