Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitLab CI #97

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Update GitLab CI #97

merged 3 commits into from
Sep 5, 2024

Conversation

rbberger
Copy link
Collaborator

@rbberger rbberger commented Sep 4, 2024

PR Summary

PR Checklist

  • Code is formatted. (You can use the format_spiner make target.)
  • Adds a test for any bugs fixed. Adds tests for new features.
  • If preparing for a new release, update the version in cmake.

Yurlungur
Yurlungur approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this one too! Might be worth copy-pasting your documentation from singularity into the docs here too.

@rbberger
Copy link
Collaborator Author

rbberger commented Sep 4, 2024

@Yurlungur Looks like Spiner is missing the entire contributing page. Sounds like this should be its own PR.

@Yurlungur
Copy link
Collaborator

That's fair. Let's get this in then.

@Yurlungur Yurlungur merged commit 6301440 into main Sep 5, 2024
5 checks passed
@rbberger rbberger deleted the use_xcap_spack_env branch September 5, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbberger @Yurlungur