Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup test PTE structure and remove variant from shared header #420

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Sep 25, 2024

PR Summary

What it says on the can. In a previous MR (where I was cleaning things up) I broke the test in test_get_sg_eos. I'm not sure why the CI didn't catch this---going to leave that mystery to @rbberger . To reproduce, build with at least

cmake -DSINGULARITY_USE_KOKKOS=ON -DSINGULARITY_BUILD_TESTS=ON -DSINGULARITY_USE_FORTRAN=ON -DSINGULARITY_FORCE_SUBMODULE_MODE=ON ..

This MR resolves the issue and also cleans up the organization of the tests a bit by:

  • Renaming the offending header file something more descriptive
  • Moving the variant declarations (when they are needed by tests) into the implementation files
  • Making the tests not depend on include order by more properly templating the set_eos function

I also thread through a missing cmake definition for fast logs. Unrelated to the rest of this MR.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

@Yurlungur Yurlungur added bug Something isn't working Testing Additions/changes to the testing infrastruture labels Sep 25, 2024
@Yurlungur Yurlungur self-assigned this Sep 25, 2024
CMakeLists.txt Show resolved Hide resolved
test/pte_test_3mat_analytic.hpp Show resolved Hide resolved
@Yurlungur
Copy link
Collaborator Author

I think on github builds this was missed due to not building with kokkos. Added a build matrix that builds against kokkos to make sure we catch it.

@Yurlungur Yurlungur merged commit f44aadb into main Sep 25, 2024
6 checks passed
@Yurlungur Yurlungur deleted the jmm/fix-test-get-sg-eos branch September 25, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Testing Additions/changes to the testing infrastruture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants