Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for ATS4 #419

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Changes for ATS4 #419

merged 5 commits into from
Sep 30, 2024

Conversation

rbberger
Copy link
Collaborator

@rbberger rbberger commented Sep 24, 2024

PR Summary

  • adds CI for ATS4
  • updates patch for spark-variant to support ROCm

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Ensure that any when='@main' dependencies are updated to the release version in the package.py

@rbberger rbberger force-pushed the rberger/ats4 branch 9 times, most recently from c772bc3 to f1d45de Compare September 24, 2024 23:06
@rbberger rbberger marked this pull request as ready for review September 25, 2024 21:29
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to have this in. Please update Kokkos in the submodule and the spackage too if needed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This is a good addition.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for splitting this out

@rbberger
Copy link
Collaborator Author

I still want to update this next week to use the Cray Fortran compiler to enable building our Fortran interfaces. I already tested this, I just need to propagate this to the CI. We do also have an issue of very slow build times with -O1 or higher.

@rbberger rbberger merged commit 1307c49 into main Sep 30, 2024
6 checks passed
@rbberger rbberger deleted the rberger/ats4 branch September 30, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants