Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed max compile errors flag #316

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Removed max compile errors flag #316

merged 2 commits into from
Oct 22, 2023

Conversation

mauneyc-LANL
Copy link
Collaborator

@mauneyc-LANL mauneyc-LANL commented Oct 22, 2023 •
edited
Loading

PR Summary

For #315 , this removes fmax-errors=3 from the singularity-eos build flags. I had put this in when debugging a build, but forgot to remove it later.

  • After creating a pull request, note it in the CHANGELOG.md file

@mauneyc-LANL mauneyc-LANL self-assigned this Oct 22, 2023
Yurlungur
Yurlungur approved these changes Oct 22, 2023
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, @mauneyc-LANL . This is trivial enough I'm going to skip the changelog.

@mauneyc-LANL
Copy link
Collaborator Author

Thanks for the quick fix, @mauneyc-LANL . This is trivial enough I'm going to skip the changelog.

too late

@Yurlungur Yurlungur merged commit 7985c18 into main Oct 22, 2023
4 checks passed
@Yurlungur Yurlungur deleted the mauneyc/fix/remove_max_err branch October 22, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

Assignees

@mauneyc-LANL mauneyc-LANL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauneyc-LANL @Yurlungur