Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test hdf5 logic #287

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Fix test hdf5 logic #287

merged 4 commits into from
Aug 4, 2023

Conversation

mauneyc-LANL
Copy link
Collaborator

@mauneyc-LANL mauneyc-LANL commented Aug 4, 2023

PR Summary

In #246 , SINGULARITY_USE_HDF5 was removed as a CMake option (it remains as a compiler definition), replaced with SINGULARITY_USE_SPINER_WITH_HDF5.

The CMake in test/CMakeLists.txt retained a condition that checked SINGULARITY_USE_HDF5 to enable a set of tests. This was removed to allow the expected tests to build. Due to the use of dependent options introduced in #246, the appropriate SINGULARITY_TEST_* flags are only exposed and enabled if SINGULARITY_USE_SPINER_WITH_HDF5 is true.

Due to erroneously skipping tests, the stellar collapse and eospac comparison tests were missed last time around and didn't catch the updates related spiner. These are updated as well. Also updated CHANGELOG.md since I missed that previously.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file
  • If preparing for a new release, update the version in cmake.

@mauneyc-LANL
Copy link
Collaborator Author

All CI's passing, with correct tests this time.

Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I see the tests are present and passing here and on re-git.

@Yurlungur Yurlungur merged commit 651d996 into main Aug 4, 2023
4 checks passed
@Yurlungur Yurlungur deleted the mauneyc/fix-test-hdf5-logic branch August 4, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants