Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document process for adding a new EOS #214

Merged
merged 4 commits into from
Jan 9, 2023
Merged

Document process for adding a new EOS #214

merged 4 commits into from
Jan 9, 2023

Conversation

jhp-lanl
Copy link
Collaborator

@jhp-lanl jhp-lanl commented Jan 5, 2023

PR Summary

Adds a section to the contributing page on adding a new EOS

@aematts please let me know if there's anything more you think could be helpful based off of your recent experience.

@Yurlungur and @dholladay00 please also review to make sure I didn't miss/oversimplify/misrepresent anything.

Fixes #194

PR Checklist

  • N/A Adds a test for any bugs fixed. Adds tests for new features.
  • N/A Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • N/A Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file
  • N/A If preparing for a new release, update the version in cmake.

@jhp-lanl jhp-lanl added the documentation Improvements or additions to documentation label Jan 5, 2023
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @jhp-lanl ! And for cleaning up some of the other bits.

@Yurlungur Yurlungur merged commit 52a459d into main Jan 9, 2023
@Yurlungur Yurlungur deleted the jhp_developer_doc branch January 9, 2023 16:27
@jhp-lanl
Copy link
Collaborator Author

@aematts even though this PR is merged, if you have additional suggestions for information that would be helpful in creating a new EOS, feel free to comment here (or create another issue), and I'll address them in a new MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to developer documentation
2 participants