Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip test based on content of scico/data/examples #99

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

bwohlberg
Copy link
Collaborator

Skip test based on content of scico/data/examples rather than content of of data directory.

Still to be confirmed that this modified skip test still achieves the original goal of skipping the tests for scico.data when run within a cloned repo without the scico-data submodule present.

Resolves #98.

@bwohlberg bwohlberg added the tests Pertaining to SCICO tests label Nov 16, 2021
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #99 (a9330b5) into main (4684909) will not change coverage.
The diff coverage is n/a.

❗ Current head a9330b5 differs from pull request most recent head 27932aa. Consider uploading reports for the commit 27932aa to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files          42       42           
  Lines        2981     2981           
=======================================
  Hits         2688     2688           
  Misses        293      293           
Flag Coverage Δ
unittests 90.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4684909...27932aa. Read the comment docs.

Copy link
Contributor

@FernandoDavis FernandoDavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed skipif condition to match general case. Works as expected in a new repo.

@bwohlberg bwohlberg merged commit 5e4ea28 into main Nov 16, 2021
@bwohlberg bwohlberg deleted the brendt/data-test-fix branch November 16, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pertaining to SCICO tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests for scico.data fail when run on installed package
2 participants