Add function to compute operator norm #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 89.12% 89.16% +0.04%
==========================================
Files 43 43
Lines 2978 2980 +2
==========================================
+ Hits 2654 2657 +3
+ Misses 324 323 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -58,6 +57,40 @@ def power_iteration(A: LinearOperator, maxiter: int = 100, key: Optional[PRNGKey | |||
| return mu, v | |||
|
|
|||
|
|
|||
| def operator_norm(A: LinearOperator, maxiter: int = 100, key: Optional[PRNGKey] = None): | |||
There was a problem hiding this comment.
idea: it might be convenient to also have a norm property on LinearOperators that can be set during construction if it is easy to compute. Circulant convolutions come to mind. Then optimizers that want the norm can see if A.norm is not None before running the potentially expensive power iteration.
Michael-T-McCann
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function to compute operator norm.