-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various changes #549
Various changes #549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added optional suggestions.
docs/source/contributing.rst
Outdated
|
||
:: | ||
|
||
conda create -n scico python=3.9 | ||
conda create -n scico python=3.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest conda create -n temp "python>=3.10,<3.13"
as a more future-proof option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe conda create -n scico python=3.10
if that really is the version that is most thoroughly tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switched to 3.12, which is the current stable version, and also the version tested in scico CI.
docs/source/install.rst
Outdated
``jaxlib`` on Windows. However, Windows users can use SCICO via the | ||
`Windows Subsystem for Linux | ||
thoroughly tested, and is the minimum supported Python version for | ||
the most recent versions of JAX.) It is supported on both Linux and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"It is supported..." -> "SCICO is supported"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
misc/conda/README.rst
Outdated
|
||
:: | ||
|
||
./make_conda_env.sh -y -e py39 | ||
./make_conda_env.sh -y -e py310 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this env should be called scico
to make it more consistent with docs/source/contributing.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
scico/_version.py
Outdated
@@ -43,14 +41,7 @@ def variable_assign_value(path: str, var: str) -> Any: | |||
try: | |||
# See http://stackoverflow.com/questions/2058802 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could link directly to the answer used, which I think is https://stackoverflow.com/a/30471662
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Various changes, primarily related to documentation, including discussion of supported Python version.