Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2D X-ray projector bugs #537

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Fix 2D X-ray projector bugs #537

merged 5 commits into from
Jul 9, 2024

Conversation

Michael-T-McCann
Copy link
Contributor

@Michael-T-McCann Michael-T-McCann commented Jul 1, 2024 •
edited
Loading

closes #534

bwohlberg
bwohlberg previously approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@bwohlberg bwohlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bwohlberg bwohlberg added bug Something isn't working examples Pertaining to SCICO examples labels Jul 2, 2024
@bwohlberg bwohlberg dismissed their stale review July 2, 2024 12:55

Noticed some issues after approving.

bwohlberg
bwohlberg reviewed Jul 2, 2024
View reviewed changes
scico/linop/xray/_xray.py Outdated Show resolved Hide resolved
bwohlberg
bwohlberg reviewed Jul 2, 2024
View reviewed changes
scico/linop/xray/_xray.py Outdated Show resolved Hide resolved
bwohlberg
bwohlberg reviewed Jul 2, 2024
View reviewed changes
scico/linop/xray/_xray.py Outdated Show resolved Hide resolved
bwohlberg
bwohlberg reviewed Jul 2, 2024
View reviewed changes
scico/linop/xray/_xray.py Outdated Show resolved Hide resolved
Michael-T-McCann
Michael-T-McCann commented Jul 9, 2024
View reviewed changes
examples/scripts/ct_multi_cs_tv_admm.py Show resolved Hide resolved
scico/linop/xray/_xray.py Outdated Show resolved Hide resolved
examples/scripts/ct_multi_cs_tv_admm.py Show resolved Hide resolved
@bwohlberg bwohlberg merged commit 722846d into main Jul 9, 2024
18 checks passed
@bwohlberg bwohlberg deleted the mike/2d_xray_edge branch July 9, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwohlberg bwohlberg bwohlberg approved these changes

Assignees
No one assigned
Labels
bug Something isn't working examples Pertaining to SCICO examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apparent regression in linop.Parallel2dProjector
2 participants
@Michael-T-McCann @bwohlberg