Resolve #530 #531
Merged
Resolve #530 #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -122,6 +122,11 @@ def test_adjoint_typical_input(testobj): | |||
| adjoint_test(A, x=x, rtol=get_tol()) | |||
|
|
|||
|
|
|||
| def test_fbp(testobj): | |||
| x = testobj.A.fbp(testobj.y) | |||
| assert np.sum(np.abs(x)) > 0.0 | |||
There was a problem hiding this comment.
Consider checking that x is reasonably close to testobj.x.
There was a problem hiding this comment.
That did occur to me, but I decided against it because it wasn't obvious how to choose a reasonable threshold for "reasonably close". But easy to add if you think it's nevertheless worthwhile.
There was a problem hiding this comment.
On further consideration, I think what I'd prefer is a comment to the effect of "checks for bug where fbp would return all zeros when because ASTRA CPU FBP algorithm was being called on a GPU system."
There was a problem hiding this comment.
Done. Please confirm approval.
crstngc
approved these changes
Jun 12, 2024
Michael-T-McCann
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #530.