-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve TVNorm
implementation
#526
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwohlberg
added
the
improvement
Improvement of existing code, including addressing of omissions or inconsistencies
label
May 29, 2024
Some timing comparisons. On import scico.numpy as snp
from scico.functional import IsotropicTVNorm
from scico.random import randn
N = 1024
x, key = randn((N, N), seed=123)
TV = IsotropicTVNorm(circular=False, ndims=2, input_shape=x.shape)
y = TV(x)
%timeit TV(x).block_until_ready()
>> 10 ms ± 81.5 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
y = TV.prox(x)
%timeit TV.prox(x).block_until_ready()
>> 88.1 ms ± 1.53 ms per loop (mean ± std. dev. of 7 runs, 10 loops each) On the branch for this PR: import scico.numpy as snp
from scico.functional import IsotropicTVNorm
from scico.random import randn
N = 1024
x, key = randn((N, N), seed=123)
TV = IsotropicTVNorm(circular=False, axes=None, input_shape=x.shape)
y = TV(x)
%timeit TV(x).block_until_ready()
>> 9.99 ms ± 55 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
y = TV.prox(x)
%timeit TV.prox(x).block_until_ready()
>> 25.8 ms ± 273 µs per loop (mean ± std. dev. of 7 runs, 10 loops each) |
Michael-T-McCann
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
improvement
Improvement of existing code, including addressing of omissions or inconsistencies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the implementation of
scico.functional.TVNorm
, recucing memory requirements and computation time.A number of other minor changes are also included in this PR.