Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix L21Norm handling of BlockArray input #506

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Fix L21Norm handling of BlockArray input #506

merged 3 commits into from
Feb 28, 2024

Conversation

bwohlberg
Copy link
Collaborator

Fix L21Norm handling of BlockArray input, which currently results in multi-valued output in evaluation of the norm.

@bwohlberg bwohlberg added the bug Something isn't working label Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 94.67%. Comparing base (19f8668) to head (3663468).

Files Patch % Lines
scico/functional/_norm.py 71.43% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
- Coverage   94.70%   94.67%   -0.03%     
==========================================
  Files          91       91              
  Lines        5703     5707       +4     
==========================================
+ Hits         5401     5403       +2     
- Misses        302      304       +2     
Flag Coverage Δ
unittests 94.67% <71.43%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bwohlberg bwohlberg merged commit 7f156a2 into main Feb 28, 2024
19 checks passed
@bwohlberg bwohlberg deleted the brendt/l21norm branch February 28, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants