Correctly check for nested tuple in map_func_over_tuple_of_tuples #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #500 +/- ##
==========================================
- Coverage 94.79% 94.77% -0.02%
==========================================
Files 91 91
Lines 5640 5641 +1
==========================================
Hits 5346 5346
- Misses 294 295 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bwohlberg
approved these changes
Feb 7, 2024
bwohlberg
added a commit
that referenced
this pull request
Feb 7, 2024
bwohlberg
added a commit
that referenced
this pull request
Feb 15, 2024
* Clean up * Work in progress: avoid creating a potentially large diagonal array for every Identity linop * Trivial edit * Typo fix * Resolve some bugs * Remove dependence of behaviour on order of operands * Update year * Remove attempt to impose commutative behaviour * Clean up post #500 bug fix * Clean up * Scaling of an Identity returns a LinearOperator, not a Diagonal * Add some tests * Add ScaledIdentity linop * Make binary operator behaviour commutative * Add some tests * Clean up * Resolve mypy errors * Address PR review comment * Fix bug identified in PR review * Add tests * Wrapper simplification in progress * Clean up _wrap_add_sub. Partially addresses #502 * Remove need for overriding __rmul__ * Remove now-unneccesary __rmul__ definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #499