-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flax checkpoint updates #472
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
==========================================
+ Coverage 94.58% 94.80% +0.22%
==========================================
Files 90 90
Lines 5608 5618 +10
==========================================
+ Hits 5304 5326 +22
+ Misses 304 292 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering the magnitude of the changes, it would be worth adding an entry in CHANGES.rst
.
Will this PR close #409? |
Entries to Note that the adaptation of the CLU library implemented to display model parameters remains since the analogous functionality in Flax (based on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor issue remaining.
The focus of this PR is to enable Orbax checkpointing of Flax models and remove an obsolete dependency on Tensorflow.