Add a jax-based X-ray projector #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #433 +/- ##
==========================================
- Coverage 94.41% 93.32% -1.08%
==========================================
Files 86 87 +1
Lines 5470 5512 +42
==========================================
- Hits 5164 5144 -20
- Misses 306 368 +62
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bwohlberg
reviewed
Jul 29, 2023
| from ._linop import LinearOperator | ||
|
|
||
|
|
||
| class XRayProject(LinearOperator): |
There was a problem hiding this comment.
Naming is not consistent with existing CT projector classes: worth discussion.
There was a problem hiding this comment.
discussion: RadonTransform here, change the others in a separate PR
There was a problem hiding this comment.
New discussion: XRayTransform
bwohlberg
reviewed
Jul 29, 2023
bwohlberg
reviewed
Jul 29, 2023
Michael-T-McCann
force-pushed
the
mike/2D_CT_projector
branch
from
27fecba
to
83d129f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, it's the simplest (2D, not very configurable) example. Extension to 3D slice-by-slice should be straightforward.
The structure of the code requires input. I designed this so that the projector could easily be cut and pasted outside of SCICO if desired.
Timing versus ASTRA is encouraging, see
ct_projector_comparison.py.