Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs improvements #430

Merged
merged 11 commits into from
Jul 19, 2023
Merged

Docs improvements #430

merged 11 commits into from
Jul 19, 2023

Conversation

bwohlberg
Copy link
Collaborator

Various docs fixes and improvements.

@bwohlberg bwohlberg added the documentation Improvements or additions to documentation label Jul 15, 2023
@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #430 (3fb8897) into main (5c7f6ba) will decrease coverage by 0.23%.
The diff coverage is 78.12%.

❗ Current head 3fb8897 differs from pull request most recent head ca0a400. Consider uploading reports for the commit ca0a400 to get more accurate results

@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   94.86%   94.63%   -0.23%     
==========================================
  Files          86       86              
  Lines        5426     5471      +45     
==========================================
+ Hits         5147     5177      +30     
- Misses        279      294      +15     
Flag Coverage Δ
unittests 94.63% <78.12%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/flax/examples/data_generation.py 74.10% <ø> (ø)
scico/linop/radon_svmbir.py 82.20% <ø> (-2.22%) ⬇️
scico/linop/radon_astra.py 79.65% <74.07%> (-6.84%) ⬇️
scico/examples.py 100.00% <100.00%> (ø)

Copy link
Contributor

@Michael-T-McCann Michael-T-McCann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple suggestions

@@ -111,17 +110,17 @@ Using A LinearOperator
We implement two ways to evaluate a :class:`.LinearOperator`. The first is using standard
callable syntax: ``A(x)``. The second mimics the NumPy matrix multiplication
syntax: ``A @ x``. Both methods perform shape and type checks to validate the
input before ultimately either calling `A._eval` or generating a new :class:`.LinearOperator`.
input before ultimately either calling :code:`A._eval` or generating a new :class:`.LinearOperator`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding a note about ":code:" to https://scico.readthedocs.io/en/stable/style.html#markup

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes have been reverted since it became clear that they create some severe markup consistency issues.



Subproblem Solvers
^^^^^^^^^^^^^^^^^^
Sub-Problem Solvers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chicago manual of style disagrees, https://www.chicagomanualofstyle.org/book/ed17/part2/ch07/psec089.html Section 4.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@bwohlberg bwohlberg merged commit 398564e into main Jul 19, 2023
@bwohlberg bwohlberg deleted the brendt/docs branch July 19, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants