-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs improvements #430
Docs improvements #430
Conversation
Codecov Report
@@ Coverage Diff @@
## main #430 +/- ##
==========================================
- Coverage 94.86% 94.63% -0.23%
==========================================
Files 86 86
Lines 5426 5471 +45
==========================================
+ Hits 5147 5177 +30
- Misses 279 294 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple suggestions
docs/source/include/operator.rst
Outdated
@@ -111,17 +110,17 @@ Using A LinearOperator | |||
We implement two ways to evaluate a :class:`.LinearOperator`. The first is using standard | |||
callable syntax: ``A(x)``. The second mimics the NumPy matrix multiplication | |||
syntax: ``A @ x``. Both methods perform shape and type checks to validate the | |||
input before ultimately either calling `A._eval` or generating a new :class:`.LinearOperator`. | |||
input before ultimately either calling :code:`A._eval` or generating a new :class:`.LinearOperator`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider adding a note about ":code:" to https://scico.readthedocs.io/en/stable/style.html#markup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes have been reverted since it became clear that they create some severe markup consistency issues.
docs/source/include/optimizer.rst
Outdated
|
||
|
||
Subproblem Solvers | ||
^^^^^^^^^^^^^^^^^^ | ||
Sub-Problem Solvers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chicago manual of style disagrees, https://www.chicagomanualofstyle.org/book/ed17/part2/ch07/psec089.html Section 4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Various docs fixes and improvements.