-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add broadcast_block_shapes #419
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-T-McCann
force-pushed
the
mike/146
branch
2 times, most recently
from
May 16, 2023 16:33
75763b3
to
ecb1f56
Compare
Michael-T-McCann
force-pushed
the
mike/146
branch
from
May 16, 2023 16:38
ecb1f56
to
7d2f233
Compare
Codecov Report
@@ Coverage Diff @@
## main #419 +/- ##
=======================================
Coverage 94.84% 94.85%
=======================================
Files 83 83
Lines 5281 5290 +9
=======================================
+ Hits 5009 5018 +9
Misses 272 272
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bwohlberg
reviewed
May 16, 2023
bwohlberg
reviewed
May 16, 2023
bwohlberg
reviewed
May 16, 2023
bwohlberg
approved these changes
May 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved subject to merge of #421.
* Resolve #261 (#416) * Improve markup for numpy.float32 etc. as well as some other docs improvements * Add note to style docs * Minor docs edit * Some markup changes * Resolve #165 (#415) * Add function for computing gaussian distribution * Typing fix and better default sigma * Address #165 * Fix docs typos and suppress apparently-spurious type error * Target clean also cleans _autosummary directory * Use new TypeAlias declaration * Suppress type error * Avoid pollution of docs with excessively long type alias definition * Add comment as per PR review suggestion * Resolve #83 (#417) * Attempt to remove rtd edit on github button * Bump jaxlib/jax max versions * Remove function no longer in jax.numpy * Resolve #377 (#418) * Fix markup * Docstring edits * Change sphinx theme * Docstring fixes * Theme customization * Clean up * Fix inheritance diagram insertion * Resolve document not in any toctree warning for index.ipynb * Clean up * Update submodule * Adjust css * Avoid problems with dark mode * Add version number in sidebar * Change inheritance diagram color scheme * Clean up * Correct path to docs_requirements --------- Co-authored-by: Thilo Balke <[email protected]> * Implement PR review recommendations --------- Co-authored-by: Thilo Balke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #146.