Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace generic Exception with more specific exceptions where possible #405

Merged
merged 6 commits into from
Apr 19, 2023

Conversation

bwohlberg
Copy link
Collaborator

@bwohlberg bwohlberg commented Apr 14, 2023

Replace generic Exception with more specific exceptions where possible. Add pre-commit and CI tests for use of raises Exception.

@bwohlberg bwohlberg added the standards Coding standards issues or violations label Apr 14, 2023
@bwohlberg bwohlberg linked an issue Apr 14, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #405 (bb1f393) into main (f88e6f2) will not change coverage.
The diff coverage is 0.00%.

❗ Current head bb1f393 differs from pull request most recent head 96b83ff. Consider uploading reports for the commit 96b83ff to get more accurate results

@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   94.27%   94.27%           
=======================================
  Files          84       84           
  Lines        5063     5063           
=======================================
  Hits         4773     4773           
  Misses        290      290           
Flag Coverage Δ
unittests 94.27% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/linop/radon_svmbir.py 86.32% <0.00%> (ø)
scico/optimize/_admm.py 96.77% <0.00%> (ø)
scico/optimize/_pgm.py 97.14% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Michael-T-McCann Michael-T-McCann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

@bwohlberg bwohlberg merged commit b738a2d into main Apr 19, 2023
@bwohlberg bwohlberg deleted the brendt/broad-exception branch April 19, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
standards Coding standards issues or violations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of generic Exception
2 participants