Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jaxlib/jax minimum versions #399

Merged
merged 12 commits into from
Apr 20, 2023
Merged

Bump jaxlib/jax minimum versions #399

merged 12 commits into from
Apr 20, 2023

Conversation

bwohlberg
Copy link
Collaborator

Bump jaxlib/jax minimum versions to resolve #378.

@bwohlberg bwohlberg added tests Pertaining to SCICO tests packaging Issues related to packaging, dependencies, etc. labels Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #399 (92b56f3) into main (016eb60) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #399   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files          83       83           
  Lines        5103     5103           
=======================================
  Hits         4819     4819           
  Misses        284      284           
Flag Coverage Δ
unittests 94.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/linop/_util.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bwohlberg
Copy link
Collaborator Author

Dropping the upper bound on the flax version appears to resolve #394.

@bwohlberg bwohlberg linked an issue Apr 18, 2023 that may be closed by this pull request
requirements.txt Outdated
flax>=0.5.1,<=0.6.1
jaxlib>=0.4.3,<=0.4.7
jax>=0.4.3,<=0.4.8
flax>=0.6.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upper bound?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added back in as 0.6.9.

@@ -93,6 +93,17 @@ For lists of the remaining wrapped functions, see
>>> scico.scipy.special.functions # doctest: +ELLIPSIS
('betainc', ...)

Note that:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bwohlberg bwohlberg merged commit 418865f into main Apr 20, 2023
@bwohlberg bwohlberg deleted the brendt/issue#344 branch April 20, 2023 19:44
@bwohlberg bwohlberg linked an issue Apr 20, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Issues related to packaging, dependencies, etc. tests Pertaining to SCICO tests
Projects
None yet
2 participants