Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce github pytest workflow runtime using pytest-split #390

Merged
merged 23 commits into from
Apr 10, 2023
Merged

Reduce github pytest workflow runtime using pytest-split #390

merged 23 commits into from
Apr 10, 2023

Conversation

bwohlberg
Copy link
Collaborator

Reduce github pytest workflow runtime using pytest-split.

@bwohlberg bwohlberg added tests Pertaining to SCICO tests developer Developer environment: issues related to CI, git, etc. labels Apr 8, 2023
@codecov
Copy link

codecov bot commented Apr 8, 2023 •
edited
Loading

Codecov Report

Merging #390 (5c5adba) into main (b8971ef) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
+ Coverage   94.25%   94.27%   +0.01%     
==========================================
  Files          84       84              
  Lines        5064     5064              
==========================================
+ Hits         4773     4774       +1     
+ Misses        291      290       -1
Flag Coverage Δ
unittests 94.27% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/optimize/_padmm.py 90.07% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bwohlberg bwohlberg closed this Apr 8, 2023
@bwohlberg bwohlberg reopened this Apr 8, 2023
@bwohlberg bwohlberg linked an issue Apr 8, 2023 that may be closed by this pull request
Unit tests are slow in CI #368
Closed
@bwohlberg bwohlberg mentioned this pull request Apr 9, 2023
Closed
Michael-T-McCann
Michael-T-McCann reviewed Apr 10, 2023
View reviewed changes
Copy link
Contributor

@Michael-T-McCann Michael-T-McCann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! One thought on Python version (see comment) otherwise good to go.

.github/workflows/lint.yml
with:
python-version: "3.8"

python-version: "3.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs state "SCICO requires Python version 3.7 or later." Given that, I suggest that it would be safer to run the tests on 3.7, as I assume code that works in 3.7 will also work in 3.9 but probably not the reverse.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I agree. I would argue that it's more important to test against the "recommended" version of Python than the minimal supported version. It's perhaps a bit more likely that code that works in 3.7 will work in 3.9 than vice-versa, but it's far more serious if it doesn't work in 3.9 since 3.7 is only supported to allow use of google colab. Perhaps a reasonable alternative would be to introduce a periodic (weekly or montly) test across multiple Python version, along the same lines as the existing "jax latest" test.

.github/workflows/mypy.yml
with:
python-version: 3.8
python-version: "3.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment on python version.

.github/workflows/pypi_upload.yml
with:
python-version: 3.8
python-version: "3.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version

.github/workflows/pytest_latest.yml
with:
python-version: 3.8
python-version: "3.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version

.github/workflows/pytest_ubuntu.yml
@@ -44,15 +35,15 @@ jobs:
miniforge-version: latest
activate-environment: test-env
use-mamba: true
python-version: 3.9
python-version: "3.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version

.github/workflows/pytest_ubuntu.yml
- name: Set up Python 3.9
uses: actions/setup-python@v4
with:
python-version: "3.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version

.github/workflows/test_examples.yml
@@ -41,10 +33,10 @@ jobs:
miniforge-version: latest
activate-environment: test-env
use-mamba: true
python-version: 3.9
python-version: "3.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version

@bwohlberg bwohlberg merged commit b6796c2 into main Apr 10, 2023
@bwohlberg bwohlberg deleted the brendt/pytest-ci branch April 10, 2023 21:11
@bwohlberg bwohlberg mentioned this pull request Apr 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-T-McCann Michael-T-McCann Michael-T-McCann left review comments

Assignees
No one assigned
Labels
developer Developer environment: issues related to CI, git, etc. tests Pertaining to SCICO tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit tests are slow in CI
2 participants
@bwohlberg @Michael-T-McCann