Update favicon and fix pre-commit hook helper script #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwohlberg
added
documentation
Codecov Report
@@ Coverage Diff @@
## main #384 +/- ##
=======================================
Coverage 94.24% 94.24%
=======================================
Files 84 84
Lines 5059 5059
=======================================
Hits 4768 4768
Misses 291 291
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tbalke
reviewed
Mar 15, 2023
.github/isbin.sh
Outdated
| echo "file exceeds maximum allowable size" | ||
| echo "raw data and ipynb files should go in scico-data" | ||
| exit 1 | ||
| echo "file exceeds maximum allowable size" |
There was a problem hiding this comment.
Worth considering to also print the maximum size.
tbalke
reviewed
Mar 15, 2023
| echo "raw data and ipynb files should go in scico-data" | ||
| exit 2 | ||
| echo "binary files cannot be commited to the repository" | ||
| echo "raw data and ipynb files should go in scico-data" |
There was a problem hiding this comment.
Yes, with a very small number of exceptions (such as scico.ico).
tbalke
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the favicon for the sphinx docs and make
.github/isbin.shcompatible with MacOS bash to resolve #383.