Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #369

Merged
merged 5 commits into from
Nov 30, 2022
Merged

Update dependencies #369

merged 5 commits into from
Nov 30, 2022

Conversation

bwohlberg
Copy link
Collaborator

@bwohlberg bwohlberg commented Nov 28, 2022

  • Bump maximum jaxlib/jax versions.
  • Bump minimum bm3d/bm4d versions to exclude versions with problematic subnormal float handling.
  • Remove warning and test related to subnormal float handling issue.
  • Move bm4d to main requirements file.
  • Adjust some test tolerances to account for changes in bm3d/bm4d behaviour.

Resolves recent failure of unit tests -- latest jax test in CI.

@bwohlberg bwohlberg added tests Pertaining to SCICO tests developer Developer environment: issues related to CI, git, etc. labels Nov 28, 2022
@bwohlberg bwohlberg marked this pull request as draft November 28, 2022 22:08
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #369 (3658075) into main (2b7da48) will increase coverage by 0.08%.
The diff coverage is 97.29%.

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   94.10%   94.19%   +0.08%     
==========================================
  Files          57       57              
  Lines        3378     3395      +17     
==========================================
+ Hits         3179     3198      +19     
+ Misses        199      197       -2     
Flag Coverage Δ
unittests 94.19% <97.29%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/optimize/__init__.py 100.00% <ø> (ø)
scico/_autograd.py 90.90% <91.66%> (ø)
scico/denoiser.py 89.02% <100.00%> (-0.75%) ⬇️
scico/linop/__init__.py 100.00% <100.00%> (ø)
scico/linop/_util.py 100.00% <100.00%> (ø)
scico/operator/_operator.py 95.00% <100.00%> (+2.50%) ⬆️
scico/optimize/_primaldual.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bwohlberg bwohlberg marked this pull request as ready for review November 29, 2022 01:14
@bwohlberg bwohlberg merged commit f8b8e41 into main Nov 30, 2022
@bwohlberg bwohlberg deleted the brendt/bm3d-update branch November 30, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Developer environment: issues related to CI, git, etc. tests Pertaining to SCICO tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants