Add DnCNN with noise level input #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wjgancn/dnnm_testing
…wjgancn/dnnm_testing
Codecov Report
@@ Coverage Diff @@
## main #349 +/- ##
==========================================
- Coverage 94.15% 94.10% -0.06%
==========================================
Files 57 59 +2
Lines 3406 3578 +172
==========================================
+ Hits 3207 3367 +160
- Misses 199 211 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I would suggest to use N as the suffix to denote the noise-conditional models instead of V. Let me ask for other suggestions before proceeding with any change. |
crstngc
reviewed
Oct 4, 2022
bwohlberg
reviewed
Oct 5, 2022
bwohlberg
reviewed
Oct 5, 2022
bwohlberg
reviewed
Oct 5, 2022
bwohlberg
reviewed
Oct 5, 2022
|
I have revised my code based on your suggestions. Especially, I rewrote the DnCNN denoiser class, which is a bit large change from my viewpoint. Maybe having a new class of denoiser is a better idea, but it also comes with code redundancy. |
…wjgancn/dnnm_testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DnCNN with noise level input.