Mitigate impact of #342 #343
Conversation
Codecov Report
@@ Coverage Diff @@
## main #343 +/- ##
==========================================
+ Coverage 93.95% 93.96% +0.01%
==========================================
Files 58 58
Lines 3493 3499 +6
==========================================
+ Hits 3282 3288 +6
Misses 211 211
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -5,7 +5,26 @@ | |||
| # user license can be found in the 'LICENSE' file distributed with the | |||
| # package. | |||
|
|
|||
| """Denoisers.""" | |||
| """ | |||
There was a problem hiding this comment.
The user sees this when looking carefully at the source code or with help(scico.denoiser). Do you think this is enough? Perhaps if these packages are installed there could be an additional warning at the time of import?
There was a problem hiding this comment.
The user should also see this when looking at the online API docs for scico.denoisers. Good question as to whether it's enough. A warning on importing the module is not a bad idea.
scico/denoiser.py
Outdated
| sufficient to inflict this loss of numerical precision on all other | ||
| calculations run within the same process, even if :func:`bm4d` is not | ||
| actually used. Users who are not making use of :func:`bm4d` are | ||
| advised not to install the corresponding package. For additional information, see `scico issue #342 <https://github.com/lanl/scico/issues/342>`__. |
| ) | ||
| warnings.filterwarnings( | ||
| action="ignore", | ||
| message="^The value of the smallest subnormal", |
There was a problem hiding this comment.
is this caret character there on purpose?
There was a problem hiding this comment.
Yes, message is a regex.
Mitigate impact of #342.