Resolve some components of #228 #340
Conversation
bwohlberg
added
documentation
Codecov Report
@@ Coverage Diff @@
## main #340 +/- ##
=======================================
Coverage 93.95% 93.95%
=======================================
Files 58 58
Lines 3493 3493
=======================================
Hits 3282 3282
Misses 211 211
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
|
||
|
|
||
| Sparse Coding | ||
| ^^^^^^^^^^^^^ | ||
|
|
||
| `sparsecode_admm.py <sparsecode_admm.py>`_ | ||
| Non-negative Basis Pursuit DeNoising (ADMM) | ||
| Non-Negative Basis Pursuit DeNoising (ADMM) |
There was a problem hiding this comment.
Did we find a consensus on how we handle capitalization?
I find it odd to read COde or DeNoising
@Michael-T-McCann
There was a problem hiding this comment.
This is non-standard capitalization, but it's the one originally used to justify the BPDN acronym. I'm open to alternatives if anyone finds this version truly offensive.
| framework :cite:`venkatakrishnan-2013-plugandplay2`, using BM3D | ||
| This example demonstrates solution of a tomographic reconstruction | ||
| problem using the Plug-and-Play Priors framework | ||
| :cite:`venkatakrishnan-2013-plugandplay2`, using BM3D | ||
| :cite:`dabov-2008-image` as a denoiser and SVMBIR :cite:`svmbir-2020` for | ||
| tomographic projection. | ||
|
|
There was a problem hiding this comment.
change version to example here as well?
There was a problem hiding this comment.
Some rephrasing in both versions.
| @@ -5,13 +5,12 @@ | |||
| # with the package. | |||
|
|
|||
| """ | |||
| CT Reconstruction (ADMM Plug-and-Play Priors w/ BM3D, SVMBIR+Prox) | |||
| ================================================================== | |||
| PPP (with BM3D) CT Reconstruction (ADMM with SVMBIR Fast Prox) | |||
There was a problem hiding this comment.
Maybe call it Fast SVMBIR Prox?
Resolve some components (as indicated in issue) of #228.