Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address #335 #336

Merged
merged 5 commits into from
Sep 7, 2022
Merged

Address #335 #336

merged 5 commits into from
Sep 7, 2022

Conversation

bwohlberg
Copy link
Collaborator

Resolves #335.

@bwohlberg bwohlberg added documentation Improvements or additions to documentation improvement Improvement of existing code, including addressing of omissions or inconsistencies labels Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #336 (0ff8adc) into main (88026d2) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
- Coverage   93.95%   93.93%   -0.03%     
==========================================
  Files          58       58              
  Lines        3493     3495       +2     
==========================================
+ Hits         3282     3283       +1     
- Misses        211      212       +1     
Flag Coverage Δ
unittests 93.93% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/operator/_operator.py 92.50% <50.00%> (-0.73%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bwohlberg
Copy link
Collaborator Author

I intend ignoring the codecov complaint about the 0.03% reduction in coverage.

@bwohlberg bwohlberg merged commit 98d3df7 into main Sep 7, 2022
@bwohlberg bwohlberg deleted the brendt/issue#335 branch September 7, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation improvement Improvement of existing code, including addressing of omissions or inconsistencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apparent error in docstring for Operator.__init__
2 participants