Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block diagonal linear operator #315

Merged
merged 5 commits into from
Jul 29, 2022
Merged

Conversation

Michael-T-McCann
Copy link
Contributor

Looking for feedback: is the name appropriate? We haveBlockDiagonalLinearOperator and LinearOperatorStack, which don't seem parallel and have the awkward "LinearOperator" part.

closes #311

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #315 (4644b38) into main (7562063) will decrease coverage by 0.09%.
The diff coverage is 83.72%.

@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
- Coverage   94.03%   93.93%   -0.10%     
==========================================
  Files          54       54              
  Lines        3384     3411      +27     
==========================================
+ Hits         3182     3204      +22     
- Misses        202      207       +5     
Flag Coverage Δ
unittests 93.93% <83.72%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/linop/_stack.py 87.64% <82.50%> (-2.69%) ⬇️
scico/linop/__init__.py 100.00% <100.00%> (ø)
scico/linop/_diff.py 98.30% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@bwohlberg bwohlberg changed the title Rough in BlockDiagonalLinaerOperator Rough in BlockDiagonalLinearOperator Jul 20, 2022
@bwohlberg
Copy link
Collaborator

BlockDiagonalLinearOperator is consistent with other names in use, but it's quite the mouthful. Perhaps replace LinearOperator with LinOp in long names, or something like renaming LinearOperatorStack to LinearOperatorVStack and BlockDiagonalLinearOperator to LinearOperatorDStack?

@Michael-T-McCann Michael-T-McCann changed the title Rough in BlockDiagonalLinearOperator Add block diagonal linear operator Jul 25, 2022
scico/linop/_stack.py Outdated Show resolved Hide resolved
scico/linop/_stack.py Outdated Show resolved Hide resolved
scico/linop/_stack.py Outdated Show resolved Hide resolved
scico/linop/_stack.py Outdated Show resolved Hide resolved
scico/linop/_stack.py Outdated Show resolved Hide resolved
@Michael-T-McCann Michael-T-McCann enabled auto-merge (squash) July 29, 2022 15:18
@Michael-T-McCann Michael-T-McCann merged commit 4e485fd into main Jul 29, 2022
@bwohlberg bwohlberg deleted the mike/BlockDiagonal branch September 12, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BlockDiagonal linear operator
2 participants