Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.7 compatibility #301

Merged
merged 6 commits into from
May 23, 2022
Merged

Add Python 3.7 compatibility #301

merged 6 commits into from
May 23, 2022

Conversation

Michael-T-McCann
Copy link
Contributor

Three main changes:

  • add math.prod if it doesn't exist
  • add typing.Literal if it doesn't exist
  • change syntax of parse call in _version.py if it fails

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #301 (66f3b55) into main (4df0046) will decrease coverage by 0.18%.
The diff coverage is 53.33%.

@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   94.31%   94.13%   -0.19%     
==========================================
  Files          53       54       +1     
  Lines        3326     3340      +14     
==========================================
+ Hits         3137     3144       +7     
- Misses        189      196       +7     
Flag Coverage Δ
unittests 94.13% <53.33%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/_python37.py 33.33% <33.33%> (ø)
scico/_version.py 82.35% <80.00%> (-2.27%) ⬇️
scico/__init__.py 88.23% <100.00%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df0046...66f3b55. Read the comment docs.

scico/__init__.py Outdated Show resolved Hide resolved
scico/numpy/util.py Outdated Show resolved Hide resolved
scico/_python37.py Outdated Show resolved Hide resolved
@Michael-T-McCann Michael-T-McCann enabled auto-merge (squash) May 23, 2022 17:55
@Michael-T-McCann Michael-T-McCann merged commit 4f995ce into main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants