Improve handling of h_center parameter in linop.CircularConvolve
#299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwohlberg
added
the
improvement
Codecov Report
@@ Coverage Diff @@
## main #299 +/- ##
=======================================
Coverage 94.30% 94.31%
=======================================
Files 53 53
Lines 3321 3326 +5
=======================================
+ Hits 3132 3137 +5
Misses 189 189
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| else: | ||
| # support float or int values for h_center | ||
| if isinstance(self.h_center, (float, int)): | ||
| offset = -snp.array( |
There was a problem hiding this comment.
formatting looks slightly odd here but I assume that's black's doing
There was a problem hiding this comment.
Do you mean the relatively deeply nested if/else structure? That's just a natural consequence of the actual logic here.
Michael-T-McCann
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve handling of
h_centerparameter inlinop.CircularConvolve. Allow tuples and lists instead of just DeviceArray type, as well as float or int for one-dimensional arrays. Also add tests for this parameter.