Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve example checking script #295

Merged
merged 26 commits into from
May 11, 2022
Merged

Improve example checking script #295

merged 26 commits into from
May 11, 2022

Conversation

bwohlberg
Copy link
Collaborator

Improve example checking script and add github action to run it on PRs.

@bwohlberg bwohlberg added examples Pertaining to SCICO examples developer Developer environment: issues related to CI, git, etc. labels May 10, 2022
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #295 (64d8892) into main (70fd67f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files          53       53           
  Lines        3303     3303           
=======================================
  Hits         3112     3112           
  Misses        191      191           
Flag Coverage Δ
unittests 94.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70fd67f...64d8892. Read the comment docs.

Copy link
Contributor

@Michael-T-McCann Michael-T-McCann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works on my machine, which is a big improvement over the last version.

I did get ./scriptcheck.sh: line 113: kill: (95112) - No such process after all the examples ran, not sure the cause.

@bwohlberg bwohlberg merged commit 2eb549c into main May 11, 2022
@bwohlberg bwohlberg deleted the brendt/examples branch May 11, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Developer environment: issues related to CI, git, etc. examples Pertaining to SCICO examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants