-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve example checking script #295
Conversation
Codecov Report
@@ Coverage Diff @@
## main #295 +/- ##
=======================================
Coverage 94.21% 94.21%
=======================================
Files 53 53
Lines 3303 3303
=======================================
Hits 3112 3112
Misses 191 191
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works on my machine, which is a big improvement over the last version.
I did get ./scriptcheck.sh: line 113: kill: (95112) - No such process
after all the examples ran, not sure the cause.
Improve example checking script and add github action to run it on PRs.