ADMM extensions #29
Merged
ADMM extensions #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-T-McCann
approved these changes
Oct 7, 2021
| @@ -7,6 +7,8 @@ | |||
|
|
|||
| """ADMM solver and auxiliary classes.""" | |||
|
|
|||
| from __future__ import annotations | |||
There was a problem hiding this comment.
Is this another case of
# needed to annotate a class method that returns the encapsulating class
# see https://www.python.org/dev/peps/pep-0563/
? If so, suggest adding the comment. Otherwise people might assume this is needed in every source file.
scico/admm.py
Outdated
| @@ -383,6 +387,7 @@ def __init__( | |||
| and an ADMM object, responsible for constructing a tuple ready for insertion into | |||
| the :class:`.diagnostics.IterationStats` object. If None, default values are | |||
| used for the tuple components. | |||
| callback: An optional callback function that | |||
There was a problem hiding this comment.
"that..." something?
scico/admm.py
Outdated
| self.maxiter: int = maxiter | ||
| self.timer: Timer = Timer() | ||
| # ToDo: a None value should imply automatic selection of the solver |
There was a problem hiding this comment.
This TODO seems slightly stale, or maybe it would be better as a feature request issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solvemethod