-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore missing BlockArray
docs
#285
Conversation
Codecov Report
@@ Coverage Diff @@
## main #285 +/- ##
=======================================
Coverage 94.15% 94.15%
=======================================
Files 49 49
Lines 3267 3269 +2
=======================================
+ Hits 3076 3078 +2
Misses 191 191
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this and fixing it!
A side of effect of #259 was removal of the detailed
BlockArray
docs (see readthedocs). Fixing this requiredscico.numpy.blockarray
toscico.numpy._blockarray
since theblockarray = BlockArray.blockarray
line inscico/numpy/__init__.py
overwrote the use ofblockarray
as a submodule name..rst
file since there were additional difficulties in including the docs fromscico.numpy._blockarray
.Some attention is still required, as indicated in comments to be added after creation of the PR.