Improve SquaredL2SquaredAbsLoss
#278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #278 +/- ##
=======================================
Coverage 93.85% 93.86%
=======================================
Files 51 51
Lines 3696 3701 +5
=======================================
+ Hits 3469 3474 +5
Misses 227 227
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Michael-T-McCann
requested changes
Apr 19, 2022
scico/test/functional/test_loss.py
Outdated
|
|
||
| def test_cubic_root(): | ||
| N = 10000 | ||
| p, _ = uniform(shape=(N,), dtype=snp.float32, minval=-10.0, maxval=10.0) |
There was a problem hiding this comment.
consider seeding rng here so the test result is not stochastic
scico/test/functional/test_loss.py
Outdated
| def test_cubic_root(): | ||
| N = 10000 | ||
| p, _ = uniform(shape=(N,), dtype=snp.float32, minval=-10.0, maxval=10.0) | ||
| q, _ = uniform(shape=(N,), dtype=snp.float32, minval=-10.0, maxval=10.0) |
There was a problem hiding this comment.
jax gotcha: I think p and q will be equal if you make them this way. Need to get the key from the first call and pass it to the second.
There was a problem hiding this comment.
Indeed they were. Fixed.
Michael-T-McCann
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve algorithm, docs, and testing of the cubic equation root calculation used by
SquaredL2SquaredAbsLoss.