Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in loss module #255

Merged
merged 8 commits into from
Mar 21, 2022
Merged

Fix bugs in loss module #255

merged 8 commits into from
Mar 21, 2022

Conversation

bwohlberg
Copy link
Collaborator

Fix some bugs/oversights in initialization of linear operators.

@bwohlberg bwohlberg added bug Something isn't working improvement Improvement of existing code, including addressing of omissions or inconsistencies labels Mar 18, 2022
@codecov
Copy link

codecov bot commented Mar 18, 2022 •
edited
Loading

Codecov Report

Merging #255 (371c33b) into main (51856fc) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 371c33b differs from pull request most recent head f1d032b. Consider uploading reports for the commit f1d032b to get more accurate results

@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   93.76%   93.76%           
=======================================
  Files          49       49           
  Lines        3513     3513           
=======================================
  Hits         3294     3294           
  Misses        219      219
Flag Coverage Δ
unittests 93.76% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/optimize/admm.py 96.07% <ø> (ø)
scico/diagnostics.py 88.05% <100.00%> (ø)
scico/loss.py 94.21% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51856fc...f1d032b. Read the comment docs.

Michael-T-McCann
Michael-T-McCann requested changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@Michael-T-McCann Michael-T-McCann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine, but I don't see any changes to the linop module, which is at odds with the name of the PR. Is something missing here?

@bwohlberg bwohlberg changed the title Fix bugs in linop module Fix bugs in loss module Mar 21, 2022
@bwohlberg
Copy link
Collaborator Author

These changes look fine, but I don't see any changes to the linop module, which is at odds with the name of the PR. Is something missing here?

You're right. The change affected linop initialization, but was actually in the loss module. Title corrected accordingly.

FernandoDavis
FernandoDavis reviewed Mar 21, 2022
View reviewed changes
scico/loss.py Outdated
@@ -58,7 +58,8 @@ def __init__(
Args:
y: Measurement.
A: Forward operator. Defaults to ``None``, in which case
`self.A` is a :class:`.Identity`.
``self.A`` is a :class:`.Identity` with input shape
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backticks in self.A should be reverted I believe

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

FernandoDavis
FernandoDavis approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@FernandoDavis FernandoDavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwohlberg bwohlberg merged commit 35a5868 into main Mar 21, 2022
@bwohlberg bwohlberg deleted the brendt/bug-fix branch March 21, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-T-McCann Michael-T-McCann Michael-T-McCann approved these changes

@FernandoDavis FernandoDavis FernandoDavis approved these changes

Assignees
No one assigned
Labels
bug Something isn't working improvement Improvement of existing code, including addressing of omissions or inconsistencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwohlberg @FernandoDavis @Michael-T-McCann