Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doctest of modules to workflow, fix modules so they pass #247

Merged
merged 4 commits into from
Mar 14, 2022

Conversation

Michael-T-McCann
Copy link
Contributor

@Michael-T-McCann Michael-T-McCann commented Mar 10, 2022

Also gets the "unit tests / pytest" action to correctly install astra-toolbox and therefore not skip test_radon_astra.py.

Addresses https://github.com/scici/scico/issues/233

@Michael-T-McCann Michael-T-McCann force-pushed the mike/doctest branch 23 times, most recently from 0f08b56 to 014a1bb Compare March 10, 2022 19:59
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #247 (31152ce) into main (d9b1190) will increase coverage by 1.08%.
The diff coverage is n/a.

❗ Current head 31152ce differs from pull request most recent head 6b709f5. Consider uploading reports for the commit 6b709f5 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   92.63%   93.71%   +1.08%     
==========================================
  Files          49       49              
  Lines        3517     3517              
==========================================
+ Hits         3258     3296      +38     
+ Misses        259      221      -38     
Flag Coverage Δ
unittests 93.71% <ø> (+1.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/linop/_diff.py 92.68% <ø> (ø)
scico/util.py 90.98% <ø> (ø)
scico/linop/radon_astra.py 66.19% <0.00%> (+53.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9b1190...6b709f5. Read the comment docs.

@Michael-T-McCann Michael-T-McCann force-pushed the mike/doctest branch 6 times, most recently from 8e639e8 to 3f0954c Compare March 10, 2022 20:16
@Michael-T-McCann Michael-T-McCann force-pushed the mike/doctest branch 8 times, most recently from f270f97 to 87edac8 Compare March 10, 2022 21:17
@Michael-T-McCann
Copy link
Contributor Author

Michael-T-McCann commented Mar 10, 2022

@bwohlberg Any ideas on why the readthedocs build is failing? I notice it is (1) throwing No module named 'ipython_genutils' and (2) running python3.7. But I can't see the action to debug further and have no idea how my changes would impact it.

@bwohlberg
Copy link
Collaborator

@bwohlberg Any ideas on why the readthedocs build is failing? I notice it is (1) throwing No module named 'ipython_genutils' and (2) running python3.7. But I can't see the action to debug further and have no idea how my changes would impact it.

It doesn't seem to be related to anything in this PR. Presumably a recent change in one of the docs dependencies, possibly nbsphinx, has broken the build. I'll look into it.

@bwohlberg bwohlberg added documentation Improvements or additions to documentation tests Pertaining to SCICO tests labels Mar 11, 2022
conftest.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
@bwohlberg
Copy link
Collaborator

It doesn't seem to be related to anything in this PR. Presumably a recent change in one of the docs dependencies, possibly nbsphinx, has broken the build. I'll look into it.

Fixed in #248.

@Michael-T-McCann Michael-T-McCann merged commit 946af61 into main Mar 14, 2022
@Michael-T-McCann Michael-T-McCann deleted the mike/doctest branch March 14, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation tests Pertaining to SCICO tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants