Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bm3d dependency optional #243

Merged
merged 17 commits into from
Mar 8, 2022
Merged

Make bm3d dependency optional #243

merged 17 commits into from
Mar 8, 2022

Conversation

bwohlberg
Copy link
Collaborator

  • Make bm3d dependency optional in the sense that only functions and scripts that make direct use thereof cannot be used when it isn't installed
  • Some minor packaging improvements

@bwohlberg bwohlberg added the developer Developer environment: issues related to CI, git, etc. label Mar 7, 2022
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #243 (442ca69) into main (13be7a3) will increase coverage by 0.01%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   92.62%   92.63%   +0.01%     
==========================================
  Files          49       49              
  Lines        3512     3517       +5     
==========================================
+ Hits         3253     3258       +5     
  Misses        259      259              
Flag Coverage Δ
unittests 92.63% <72.72%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/linop/abel.py 98.21% <ø> (ø)
scico/ray/tune.py 95.65% <ø> (-0.10%) ⬇️
scico/denoiser.py 91.52% <72.72%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13be7a3...442ca69. Read the comment docs.

scico/denoiser.py Outdated Show resolved Hide resolved
@bwohlberg bwohlberg merged commit 956e55e into main Mar 8, 2022
@bwohlberg bwohlberg deleted the brendt/optional-bm3d branch March 8, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Developer environment: issues related to CI, git, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants