Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make user-facing code use scico.random instead of np.random #235

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

Michael-T-McCann
Copy link
Contributor

Address the part of https://github.com/scici/scico/issues/315 that I think is worth fixing now. There remain uses of np.random in the tests.

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #235 (3953842) into main (244b05c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #235   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          49       49           
  Lines        3452     3452           
=======================================
  Hits         3194     3194           
  Misses        258      258           
Flag Coverage Δ
unittests 92.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/blockarray.py 91.20% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 244b05c...3953842. Read the comment docs.

@Michael-T-McCann Michael-T-McCann merged commit 67da918 into main Feb 28, 2022
@Michael-T-McCann Michael-T-McCann deleted the mike/use_random branch February 28, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants