Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new example script #221

Merged
merged 10 commits into from
Feb 11, 2022
Merged

Add new example script #221

merged 10 commits into from
Feb 11, 2022

Conversation

bwohlberg
Copy link
Collaborator

Add new example script.

@bwohlberg bwohlberg added the examples Pertaining to SCICO examples label Feb 10, 2022
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #221 (a1d0a0a) into main (008b436) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files          49       49           
  Lines        3431     3431           
=======================================
  Hits         3171     3171           
  Misses        260      260           
Flag Coverage Δ
unittests 92.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/loss.py 88.34% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 008b436...a1d0a0a. Read the comment docs.



"""
Show recovered full-resolution images.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would show the ground truth image as well but just my humble opinion.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the "reference" image in the previous figure.

Copy link
Contributor

@tbalke tbalke Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, although I mean in the same figure as the reconstructions.

Not a strong opinion, though. Your call.

@bwohlberg bwohlberg merged commit c084dda into main Feb 11, 2022
@bwohlberg bwohlberg deleted the brendt/superres-example branch February 11, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Pertaining to SCICO examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants