Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous minor improvements #210

Merged
merged 7 commits into from
Feb 8, 2022
Merged

Miscellaneous minor improvements #210

merged 7 commits into from
Feb 8, 2022

Conversation

bwohlberg
Copy link
Collaborator

Miscellaneous minor improvements

@bwohlberg bwohlberg added documentation Improvements or additions to documentation improvement Improvement of existing code, including addressing of omissions or inconsistencies labels Feb 5, 2022
@bwohlberg bwohlberg requested a review from tbalke February 5, 2022 00:39
@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #210 (aafd4af) into main (3ff6945) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head aafd4af differs from pull request most recent head 91d6e2a. Consider uploading reports for the commit 91d6e2a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   92.24%   92.31%   +0.07%     
==========================================
  Files          48       48              
  Lines        3351     3358       +7     
==========================================
+ Hits         3091     3100       +9     
+ Misses        260      258       -2     
Flag Coverage Δ
unittests 92.31% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scico/_generic_operators.py 91.81% <ø> (ø)
scico/linop/_diff.py 92.68% <ø> (ø)
scico/linop/radon_svmbir.py 87.87% <ø> (ø)
scico/optimize/_ladmm.py 98.86% <ø> (ø)
scico/optimize/_primaldual.py 100.00% <ø> (ø)
scico/array.py 97.40% <100.00%> (ø)
scico/blockarray.py 91.20% <100.00%> (ø)
scico/optimize/pgm.py 96.46% <100.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff6945...91d6e2a. Read the comment docs.

README.rst Show resolved Hide resolved
Copy link
Contributor

@tbalke tbalke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve upon addressing the two minor comments.

@bwohlberg bwohlberg enabled auto-merge (squash) February 8, 2022 00:37
@bwohlberg bwohlberg merged commit 2b7a693 into main Feb 8, 2022
@bwohlberg bwohlberg deleted the brendt/misc branch February 8, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation improvement Improvement of existing code, including addressing of omissions or inconsistencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants